Server-Side Optimization

[Hack-N-Slash]

The server has been doing a great job for the majority of the time, but as of late people slowdowns and crashes are becoming increasingly common. What can be done to resolve this without sacrificing the features we have already? The server connection seems to be enough for what we're doing, but the server seems to be choking on itself.

I'm writing down a list of considerations that I'll put down later today. All the questions will be aimed at possible server code optimizations.

[Hack-N-Slash]

1. What are the most called functions?

2. What functions take the most resources per call?

3. What has already been done to improve server efficiency?

I'll finish this later

[-eViL-]

if you want to solve all the problems of a tribes rpg server, you must kill GetAccessoryList();

but to do that, you must re-write lots and lots o code.

[Hack-N-Slash]

Anything else? I'm going to browse thru the server code and look for areas for possible optimizations.

Are there any places where sorting is involved? I'd hate to see a freaking inefficient sort (bubble and the like) used all the time.

[-eViL-]

hack, i told you the biggest problem in rpg, have a nice time finding anything bigger.

and just for the proof, i'll quote JI :

//Replaces the laggy AddPoints(%clientId, in RefreshWeight (the real lag comes from GetAccessoryList however)

JI put the lag into the mod, and never removed it even though he knew it was there.

[Hack-N-Slash]

Ok, ok! *runs and hides*

[UnderGod]

Aside for the infinite loops that constantly run, and that function, there is nothing else that can really be fixed short of writing a special app to manage the server.

[Hack-N-Slash]

Wow, I just looked at getAccessoryList... frightening bit of code. Now I understand why you said that eViL: All those looped checks on player inventory.

I'm inclined to toy with it.

eViL, I also recall in the past hearing you say that fetchdata had an impact on the server as well.

[UnderGod]

In a way it does, but there is nothing you can do about that short of rewriting the entire mod.

[-eViL-]

what oz said.

but yes, fetchdata is a giant waste of server clock cycles.... it is called just about as much as the accessory list function is.

[Hack-N-Slash]

Woot, my internet has finally come back to life! The service outage got me bored enough to probe more into this.



I wouldn't mind splitting fetchdata into separate functions and rewriting the code accordingly in order to kill that huge mess of if statements. The large if block would have to be a factor in the server's problems if fetchData is called so much.

If this doesn't fix the problem, it would definitely would reduce the time calling info from $ClientData

Either that or I call information from $ClientData whereever fetchdata is called.

If I'm going about this wrong, tell me what I would need to do, in exact terms. I have LOTS of time on my hands, and I need the practice anyways.  

If I get this fixed, I'll move on to dealing with getAccessoryList.

[UnderGod]

The best way to rewrite something like the character saving function, is to turn it into 1 quick line of code that still saves everything.

[Xanth]

Is is just possible to leave the FetchData calls in and just replace the function with and empty function that does nothing?

[Hack-N-Slash]

If you want to break the mod...sure.  

The function is used to call character information from the server.

[UnderGod]

Yeah... No fetchData, no RPG.